Fix universal package version validation comment and add SHA prefix#28248
Merged
Fix universal package version validation comment and add SHA prefix#28248
Conversation
- Correct misleading 'SemVer 1.0.0' label; the universal version regex actually validates SemVer 2.0.0 syntax without build metadata, which is what Azure Universal Packages requires. - Prefix the dev short SHA with 'commit-' in universal_version so the pre-release identifier always contains a non-digit, avoiding spurious validation failures for all-numeric SHAs with leading zeros.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Azure Pipelines step that computes and validates plugin package versions so that Universal Package “dev” versions always pass SemVer validation (and the inline documentation matches the actual constraints).
Changes:
- Prefixes the dev short SHA with
commit-inuniversal_versionto avoid invalid all-numeric pre-release identifiers with leading zeros. - Corrects the Universal Packages SemVer validation comment/error text to SemVer 2.0.0 (without build metadata).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sanaa-hamel-microsoft
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Correct misleading 'SemVer 1.0.0' label; the universal version regex actually validates SemVer 2.0.0 syntax without build metadata, which is what Azure Universal Packages requires.
Prefix the dev short SHA with 'commit-' in universal_version so the pre-release identifier always contains a non-digit, avoiding spurious validation failures for all-numeric SHAs with leading zeros.
Motivation and Context
Fix invalid version when we have an all-numeric commit SHA starting with 0.